Search: user dashboard #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippgualdi
force-pushed
the
modification/user-dashboard-api
branch
from
4639462 to
c77794c
Compare
| @@ -18,8 +18,8 @@ export const Marc21RecordResultsListItem = ({ result, index }) => { | |||
| const createdDate = get(result, "ui.created", "No creation date found"); | |||
| const publicationDate = get(result, "ui.updated", "No update date found"); | |||
|
|
|||
| const access_id = get(result, "ui.access_status.id", "public"); | |||
| const access_status = get(result, "ui.access_status.title", "Public"); | |||
| const access_id = get(result, "ui.access_status.id", "open"); | |||
There was a problem hiding this comment.
this change irritates me. should the status not be "public" why is here a change to "open" necessary?
There was a problem hiding this comment.
Some time ago, Invenio changed the 'id' from 'public' to 'open' and the title from 'Public' to 'Open'. Although we haven't changed this line of code, we continue to utilize their 'access' field. This adjustment enhances consistency and readability.
| @@ -10,10 +10,7 @@ | |||
| "Manage": "Manage", | |||
| "Version": "Version", | |||
| "Preview": "Preview", | |||
| "{{count}} results found": "{{count}} results found", | |||
There was a problem hiding this comment.
Are they translations replaced by other strings?
There was a problem hiding this comment.
This translation is no longer in use since we are utilizing the count component from the search application.
There was a problem hiding this comment.
so we use the translation strings from them?
utnapischtim
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the layout for the user search an create an api endpoint to search for user records
DEMO
