Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed improvements #29

Open
DomiKoch opened this issue Jun 29, 2023 · 2 comments
Open

Speed improvements #29

DomiKoch opened this issue Jun 29, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@DomiKoch
Copy link
Contributor

Description

Hi @Mhera17 ,

we want to comply to some requirements of shopify and improve the loading time of our connector layer in the shopify backend.
image

LCP: https://shopify.dev/docs/apps/best-practices/performance/admin#largest-contentful-paint
Mobile: https://shopify.dev/docs/apps/tools/app-bridge/optimized-loading

In Lighthouse Test Desktop we are slightly above the wished LCP Limit (2,5 second):
image

In Lighthouse Test Mobile our connector is really bad.

Could you investigate, which issues are optimizeable

a) in Connector Layer
b) need to be done in baselayer

Do you have experience with that?

Greetings
Dominik

References

No response

@DomiKoch DomiKoch added the enhancement New feature or request label Jun 29, 2023
@Mhera17
Copy link
Contributor

Mhera17 commented Jul 3, 2023

HI @DomiKoch. yes, sure I have experience with that. I have changed and now testing some stuff to have better performance.I hope I will be back soon with the result

@Mhera17
Copy link
Contributor

Mhera17 commented Jul 25, 2023

hi @DomiKoch @eburck . I made some changes to the connector and event library. Hopefully, this will help us improve the speed of our application.
For EventLib, I changed the webpack configs.
for the connector, I removed 3 libraries from package.Json (Lodash, yup and @hookform/resolvers). We don't need them anymore. And created a new file for the trustBadge switcher. and did some code splitting.
Take a look, please. Hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants