Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132648 / 25.04 / query param handling for auth tokens #11080

Merged
merged 8 commits into from
Dec 5, 2024

NAS-132648: test coverage for AuthGuardService

748ebfc
Select commit
Loading
Failed to load commit list.
Merged

NAS-132648 / 25.04 / query param handling for auth tokens #11080

NAS-132648: test coverage for AuthGuardService
748ebfc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

82.45% (+0.10%) compared to cf486c8

View this Pull Request on Codecov

82.45% (+0.10%) compared to cf486c8

Details

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (cf486c8) to head (748ebfc).
Report is 53 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/core/guards/websocket-connection.guard.ts 0.00% 5 Missing ⚠️
src/app/pages/signin/store/signin.store.ts 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11080      +/-   ##
==========================================
+ Coverage   82.35%   82.45%   +0.10%     
==========================================
  Files        1630     1648      +18     
  Lines       57229    58008     +779     
  Branches     5915     5957      +42     
==========================================
+ Hits        47130    47833     +703     
- Misses      10099    10175      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.