Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Refactor solvers to share main function #73

Open
casey opened this issue Dec 19, 2018 · 1 comment
Open

Suggestion: Refactor solvers to share main function #73

casey opened this issue Dec 19, 2018 · 1 comment

Comments

@casey
Copy link
Contributor

casey commented Dec 19, 2018

I would suggest refactoring the solvers to share a single main function. Benefits would be:

  • I found a bug in Use device number supplied in args #72 which had been copied into four different files, since they were part of the main function which is duplicated across multiple files.

  • If there was a single main function shared by all the solvers, features added to that main function wouldn't need to be copied to all the main function.

Also, it would be an opportunity to rewrite the main function in rust, because why not :)

Additionally, if the main function was separated from the solvers, individual solvers could be statically linked into other programs where the flexibility of dynamic linking isn't required.

@tromp
Copy link
Owner

tromp commented Dec 19, 2018

Separating the main functions is on the todo list.
There's also a huge amount of overlap between cuckoo and cuckatoo solvers.
Eventually I will try to merge those back into one, with just a compile time option to choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants