PHP8 Errors

[dsenalik]

Under PHP 8.0 when accessing /update.php
TypeError: PDOStatement::fetchAll(): Argument #2 must be of type int, string given in PDOStatement->fetchAll() (line 2303 of .../includes/database/database.inc).

This error comes from line 449 of tripal_elasticsearch.module where fetchCol() is passed a string instead of an integer.

function tripal_elasticsearch_block_info() {
  ...
  // Define blocks for table search forms.
  $sql = "SELECT index_name FROM {tripal_elasticsearch}";
  $index_names = db_query($sql)->fetchCol('index_name');
  ...

Only one column is returned, the simple fix would be to change this to

  $index_names = db_query($sql)->fetchCol(0);

or

  $index_names = db_query($sql)->fetchCol();

[dsenalik]

Additional error encountered when unpublishing orphan nodes, exception defined as $e but referenced as $exception which is of course null:

WD php: Error: Call to a member function getMessage() on null in tripal_elasticsearch_bundle_delete_orphans()[error]
(line 1154 of .../sites/all/modules/tripal_elasticsearch/tripal_elasticsearch.module).

Adding the fix for this to pull request with e783e2b