Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this package PEP-561 compatible by adding a py.typed marker #482

Open
1 task done
Priyansh121096 opened this issue Sep 6, 2024 · 1 comment
Open
1 task done

Comments

@Priyansh121096
Copy link

Priyansh121096 commented Sep 6, 2024

Describe the feature

I see that static type checking was discussed in #69 and mypy was enabled in #91. Do people think it's a good idea to add a py.typed marker so that packages depending on trino can type check themselves against it?

Right now, there's no way to force mypy to type check against this site-packages which lack this marker (ref).

Describe alternatives you've considered

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@hashhar
Copy link
Member

hashhar commented Nov 20, 2024

Good idea, if you are still willing to send a PR we'd appreciate it. Sorry it took so long to reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants