Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlalchemy transactions with Repeatable_read #481

Open
1 task done
StephenOTT opened this issue Sep 5, 2024 · 4 comments
Open
1 task done

Sqlalchemy transactions with Repeatable_read #481

StephenOTT opened this issue Sep 5, 2024 · 4 comments

Comments

@StephenOTT
Copy link

Expected behavior

dding a isolation level in the SA Session causes a failure when using any of the levels with underscores.

Trino client is removing the underscore, but then SA requires the underscore in downstream methods for a enum lookup.

Looking at the tests, it seems like it was not tested against the isolation levels with underscores.

Thanks.

Actual behavior

Fails

Steps To Reproduce

Use isolation level REPEATABLE_READ with SA

Log output

No response

Operating System

Windoss

Trino Python client version

Latest

Trino Server version

429

Python version

3.9

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@hashhar
Copy link
Member

hashhar commented Sep 6, 2024

Thank you for the report and being willing to submit a PR. I'll take a look at the PR once it's available.

@StephenOTT
Copy link
Author

Hey @hashhar can you confirm for me: are transactions supported in the Postgres connector?

The docs seem to allude yes, but some ~random issues in this repo seem to indicate no.

@hashhar
Copy link
Member

hashhar commented Sep 9, 2024

No. Transactions are emulated for the Hive connector only as far as I remember.

cc: @mosabua Maybe we should clarify this in the docs + check what's the long term plan around transactions - will they go away eventually since we can only try to "emulate" them?

@StephenOTT
Copy link
Author

At the very least to add a big warning on this repos readme in the transaction section. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants