Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Stripe SDK to v14 #107

Open
RobertGardner opened this issue Apr 13, 2020 · 7 comments
Open

Update Android Stripe SDK to v14 #107

RobertGardner opened this issue Apr 13, 2020 · 7 comments
Assignees

Comments

@RobertGardner
Copy link
Collaborator

The plugin currently uses Stripe Android SDK v10. It needs to be upgraded to v14 (the current latest) to enable support for Google Pay, fix bugs, etc.

@RobertGardner RobertGardner self-assigned this Apr 13, 2020
@RobertGardner
Copy link
Collaborator Author

Stripe Android SDK v14 is written entirely in Kotlin (the first conversion happened at v13). There seem to be multiple issues accessing Kotlin libraries in NativeScript (or problems with how I'm trying to use it). See NativeScript/android#1604.

Once those are resolved, will resume the upgrade.

@sebj54
Copy link

sebj54 commented Sep 9, 2020

Hi @RobertGardner, do you have an update to share on this? I saw the issue you mentioned has no reply so I guess I already know the answer 😅

I just read the stripe-android's changelog and the currently used version of stripe-android is quite old now. It especially lacks SCA support (correct me if I'm wrong) which would be very interesting. SCA is required for several payments in Europe (see https://stripe.com/payments/strong-customer-authentication).

Do you think it would be a good idea to update stripe-android to version 12.8.2? Like this we won't have to deal with Kotlin.

@RobertGardner
Copy link
Collaborator Author

I would love to see it updated to 12.8.2, but unfortunately, although I said they switched to Kotlin at v13, that's actually when they made the full migration. Stripe started a small migration to Kotlin earlier than that. I have a branch to update to v12.8.2 (for historical reasons named android-12.7), but I have run into Kotlin issues on that and had to stop.

I am hoping that the {N} v7 release, with its migration to V8, will solve the Kotlin problems, but I haven't been able to get the v7 version working yet. Others are working on that, and we're waiting for NativeScript to update their plugin structure guidelines. See bug #126 .

@sebj54
Copy link

sebj54 commented Sep 10, 2020

Thanks for your detailed answer! It's more complicated than I thought :(

I will wait for that v7 update so. Glad to see it is almost ready!

@triniwiz
Copy link
Owner

@RobertGardner I'll see what I can do to get the latest sdk running for the next major release

@connorsleight
Copy link

Would it be possible to add a java intermediate layer between the kotlin code and the plugin? Or will there still be an issue with being able to access the kotlin code?

@triniwiz
Copy link
Owner

@triniwiz/nativescript-stripe uses 16+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants