From 103b4ab42d6a056961f8ee3ec5a38a0baa096b41 Mon Sep 17 00:00:00 2001 From: "Roland C. Dowdeswell" Date: Thu, 21 Sep 2023 20:27:32 +0100 Subject: [PATCH 1/2] Update variant name and app flags to match upstream --- app/Makefile | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/Makefile b/app/Makefile index 40f974e6e..5bbac3bd5 100644 --- a/app/Makefile +++ b/app/Makefile @@ -100,7 +100,7 @@ PATH_APP_LOAD_PARAMS = "44'/1729'" # * It must at least contains one value. # * Values can be the app ticker or anything else but should be unique. VARIANT_PARAM = APP_TYPE -VARIANT_VALUES = WALLET +VARIANT_VALUES = tezos_wallet # Enabling DEBUG flag will enable PRINTF and disable optimizations #DEBUG = 1 @@ -135,9 +135,11 @@ CFLAGS += -Wwrite-strings ######################################## # See SDK `include/appflags.h` for the purpose of each permission #HAVE_APPLICATION_FLAG_DERIVE_MASTER = 1 -#HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1 -#HAVE_APPLICATION_FLAG_BOLOS_SETTINGS = 1 -#HAVE_APPLICATION_FLAG_LIBRARY = 1 +ifneq ($(TARGET_NAME), TARGET_NANOS) +HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1 +HAVE_APPLICATION_FLAG_BOLOS_SETTINGS = 1 +endif +HAVE_APPLICATION_FLAG_LIBRARY = 1 ######################################## # Application communication interfaces # From 2ed1c20eecf0c043e135f6191e9862ab6e274c7d Mon Sep 17 00:00:00 2001 From: "Roland C. Dowdeswell" Date: Thu, 21 Sep 2023 15:51:38 +0100 Subject: [PATCH 2/2] Add the guidelines github workflow from app-boilerplate --- .github/workflows/guidelines_enforcer.yml | 25 +++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/guidelines_enforcer.yml diff --git a/.github/workflows/guidelines_enforcer.yml b/.github/workflows/guidelines_enforcer.yml new file mode 100644 index 000000000..e2dae281c --- /dev/null +++ b/.github/workflows/guidelines_enforcer.yml @@ -0,0 +1,25 @@ +name: Ensure compliance with Ledger guidelines + +# This workflow is mandatory in all applications +# It calls a reusable workflow guidelines_enforcer developed by Ledger's internal developer team. +# The successful completion of the reusable workflow is a mandatory step for an app to be available on the Ledger +# application store. +# +# More information on the guidelines can be found in the repository: +# LedgerHQ/ledger-app-workflows/ + +on: + workflow_dispatch: + push: + branches: + - master + - main + - develop + pull_request: + +jobs: + guidelines_enforcer: + name: Call Ledger guidelines_enforcer + uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_guidelines_enforcer.yml@v1 + with: + relative_app_directory: app