Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: add action to delete merge branches? #12270

Closed
jhux2 opened this issue Sep 15, 2023 · 8 comments
Closed

Framework: add action to delete merge branches? #12270

jhux2 opened this issue Sep 15, 2023 · 8 comments
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: question

Comments

@jhux2
Copy link
Member

jhux2 commented Sep 15, 2023

Question

@trilinos/framework Is it be possible to add a github action to delete branches that have been auto-merged? Right now, when a PR is automerged and the branch lives in the Trilinos repo, the author has to remember to delete the branch. As a result, there are a lot of dead branches, including merges to master. (Alternatively, the project could require branches to be in the author's own fork.)

@jhux2 jhux2 added type: question PA: Framework Issues that fall under the Trilinos Framework Product Area labels Sep 15, 2023
@csiefer2
Copy link
Member

It could be controlled via a Label, in case you didn't want it deleted.

@csiefer2
Copy link
Member

Here is an action that does delete on merge:

https://github.com/marketplace/actions/delete-merged-branch

@csiefer2
Copy link
Member

@sebrowne
Copy link
Contributor

I'm fully in favor of this. I'll try to remember to bring this up at TUG next week, if we get support then we can probably just turn it on.

I'll also note that I'm fully in favor of forcing the fork workflow so that the central repository does not contain WIP from developers.

@ccober6
Copy link
Contributor

ccober6 commented Oct 26, 2023

Adding to the list for open discussion topics.

@ccober6
Copy link
Contributor

ccober6 commented Feb 19, 2024

Putting on the agenda for the Operational Leadership meeting this week.

@ccober6
Copy link
Contributor

ccober6 commented Jun 3, 2024

@jhux2 , I think this is done. The autotester deletes merged branches, and we went through and cleaned old branches that people were not using. Can we close this and finished?

@jhux2
Copy link
Member Author

jhux2 commented Jun 3, 2024

Yes, I agree.

@jhux2 jhux2 closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: question
Projects
None yet
Development

No branches or pull requests

4 participants