Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoltan: new build warning #12265

Closed
jhux2 opened this issue Sep 14, 2023 · 3 comments
Closed

Zoltan: new build warning #12265

jhux2 opened this issue Sep 14, 2023 · 3 comments
Labels
pkg: Zoltan type: bug The primary issue is a bug in Trilinos code or tests

Comments

@jhux2
Copy link
Member

jhux2 commented Sep 14, 2023

Bug Report

I'm seeing a few warnings like the following:

[96/538] Building C object packages/zoltan/src/CMakeFiles/zoltan.dir/Utilities/Communication/comm_default.c.o
/ascldap/users/jhu/trilinos/Trilinos-trilinos-for-sake/packages/zoltan/src/Utilities/Communication/comm_default.c:62:25: warning: 'zoltan_global_mpi_lock' is static but used in inline function 'zoltan_initialize_global_comm' which is not static
   pthread_mutex_unlock(&zoltan_global_mpi_lock);
                         ^~~~~~~~~~~~~~~~~~~~~~
/ascldap/users/jhu/trilinos/Trilinos-trilinos-for-sake/packages/zoltan/src/Utilities/Communication/comm_default.c:61:3: warning: 'Zoltan_Global_MPI_Comm' is static but used in inline function 'zoltan_initialize_global_comm' which is not static
   Zoltan_Global_MPI_Comm = comm;
   ^~~~~~~~~~~~~~~~~~~~~~
/ascldap/users/jhu/trilinos/Trilinos-trilinos-for-sake/packages/zoltan/src/Utilities/Communication/comm_default.c:60:23: warning: 'zoltan_global_mpi_lock' is static but used in inline function 'zoltan_initialize_global_comm' which is not static
   pthread_mutex_lock(&zoltan_global_mpi_lock);
                       ^~~~~~~~~~~~~~~~~~~~~~

Could these be related to the recent work to eliminate MPI_COMM_WORLD?

@trilinos/zoltan
@JacobDomagala

@jhux2 jhux2 added type: bug The primary issue is a bug in Trilinos code or tests pkg: Zoltan labels Sep 14, 2023
@JacobDomagala
Copy link
Contributor

Probably introduced with #12195

@stmcgovern
Copy link
Contributor

I believe this issue can be closed with #PR12267 merged in.

@jhux2
Copy link
Member Author

jhux2 commented Sep 21, 2023

Thanks!

@jhux2 jhux2 closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: Zoltan type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants