Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Trilinos packages/subprojects ordering incorrect in Trilinos PR builds #10979

Open
bartlettroscoe opened this issue Sep 1, 2022 · 2 comments
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests

Comments

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Sep 1, 2022

Bug Report

@trilinos/framework

Internal Issues

Description

The Trilinos PR builds show the package/subproject ordering incorrectly on CDash. They appear to be shown in alphabetical order instead of package dependency order (as listed in the Trilinos/PackagesList.cmake file). For example, the recent PR build:

showed:

image

As a contract correct order is produced by the tribits_ctest_driver() function like shown here:

which showed:

image

The order is important to maintain so that you can see how errors in upstream packages (like MueLu) may prorogate to downstream packages (like Panzer). The is difficult to see if the ordering is not correct.

Steps to Reproduce

Run a PR build and look on CDash? There are no externally documented instructions for reproducing Trilinos ctest -S driver runs not on Jenkins.

@bartlettroscoe bartlettroscoe added type: bug The primary issue is a bug in Trilinos code or tests PA: Framework Issues that fall under the Trilinos Framework Product Area labels Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Sep 2, 2023
@bartlettroscoe bartlettroscoe added DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. and removed MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. labels Sep 4, 2023
@bartlettroscoe
Copy link
Member Author

CC: @sebrowne

This still an issue with the trilinos-cdash.sandia.gov site. The packages are listed by alphabetical order instead in dependency order (i.e. the order the appear in the Trilinos/PackagesList.cmake file). For example, you can see that here showing:

image

Contrast this with the testing.sandia.gov/cdash site that lists them correctly in dependency order as shown here showing:

image

It is valuable to view the packages in dependency order since it shows where the errors may start from and how they may impact downstream packages.

It is not clear if this is a problem with the SimpleCTestRefactor driver or the trilinos-cdash.sandia.gov/cdash site itself. But it would not be hard to experiment to figure that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

1 participant