Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: No unit test for "4-arg" variant of Distributor::doPosts "slow path" #10861

Open
tasmith4 opened this issue Aug 11, 2022 · 1 comment
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: Tpetra type: enhancement Issue is an enhancement, not a bug

Comments

@tasmith4
Copy link
Contributor

Enhancement

@trilinos/tpetra

The "4-arg" (varying number of packets per LID) variant of Distributor's doPosts operation does not have a unit test covering the "slow path" case (when the data is not contiguous by processor in the input "exports" array). There is a "doPostsNonContig" test for the "3-arg" (constant number of packets per LID) variant, which could possibly be used as a basis with some modification.

This is probably not urgent, as the code path is highly likely to be tested indirectly by other Tpetra unit tests (perhaps CrsMatrix?). However, it would aid in localizing errors to have this test.

@tasmith4 tasmith4 added type: enhancement Issue is an enhancement, not a bug pkg: Tpetra labels Aug 11, 2022
@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Aug 12, 2023
@jhux2 jhux2 added DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. and removed MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. labels Sep 8, 2023
@jhux2 jhux2 added this to Tpetra Aug 12, 2024
@jhux2 jhux2 moved this to Backlog in Tpetra Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: Tpetra type: enhancement Issue is an enhancement, not a bug
Projects
Status: Backlog
Development

No branches or pull requests

2 participants