Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 496980f breaks test 26.b #107

Open
FiachAntaw opened this issue Aug 13, 2015 · 0 comments
Open

Commit 496980f breaks test 26.b #107

FiachAntaw opened this issue Aug 13, 2015 · 0 comments

Comments

@FiachAntaw
Copy link

Running 'make test' after commit 496980f fails with a server-side handshake_failure in unit test 26.b.

This appears to be caused by filtering of the sha256 MACs in HandshakeSettings.validate() for pre-TLS 1.2 versions, which results in the server lacking any valid ciphersuites (hence no shared ciphersuites with client, hence handshake_failure). I suspect Fault.ignoreVersionForCipher is supposed to prevent this, but it only inhibits calls to CipherSuite.filterForVersion which was where filtering occurred previously.

I decided against submitting a pull request because I'm not sure what the preferred solution would be; three that come to mind are either to add fault injection to the HandshakeSettings object, to skip validation altogether if a fault has been injected, or to revert the filtering in validate() since it appears (at first glance) to be redundant.

@FiachAntaw FiachAntaw changed the title Commit 496980f breaks unit test 26.b Commit 496980f breaks test 26.b Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant