Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the all-go-deps group with 3 updates #37

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2023

Bumps the all-go-deps group with 3 updates: golang.org/x/mod, golang.org/x/sync and google.golang.org/grpc.

Updates golang.org/x/mod from 0.12.0 to 0.13.0

Commits
  • 5b69280 modfile: use new go version string format in error message
  • 273ef6c go.mod: update to go 1.18 and x/tools v0.13.0
  • See full diff in compare view

Updates golang.org/x/sync from 0.3.0 to 0.4.0

Commits

Updates google.golang.org/grpc from 1.58.1 to 1.58.2

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.58.2

Bug Fixes

  • balancer/weighted_round_robin: fix ticker leak on update

    A new ticker is created every time there is an update of addresses or configuration, but was not properly stopped. This change stops the ticker when it is no longer needed.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 9, 2023
@roger2hk
Copy link
Contributor

roger2hk commented Oct 9, 2023

It would be great if this is a PR with 3 commits, so the commit history (merged with rebase) can show the dependency version changes instead of Bump the all-go-deps group with 3 updates.

@AlCutter
Copy link
Contributor

AlCutter commented Oct 9, 2023

It would be great if this is a PR with 3 commits, so the commit history (merged with rebase) can show the dependency version changes instead of Bump the all-go-deps group with 3 updates.

Unfortunately that doesn't seem to be an option :/

@dependabot dependabot bot force-pushed the dependabot/go_modules/all-go-deps-d14d9ae022 branch from 63bd926 to 3b8468b Compare October 9, 2023 17:24
@roger2hk
Copy link
Contributor

roger2hk commented Oct 9, 2023

@dependabot recreate

Bumps the all-go-deps group with 3 updates: [golang.org/x/mod](https://github.com/golang/mod), [golang.org/x/sync](https://github.com/golang/sync) and [google.golang.org/grpc](https://github.com/grpc/grpc-go).


Updates `golang.org/x/mod` from 0.12.0 to 0.13.0
- [Commits](golang/mod@v0.12.0...v0.13.0)

Updates `golang.org/x/sync` from 0.3.0 to 0.4.0
- [Commits](golang/sync@v0.3.0...v0.4.0)

Updates `google.golang.org/grpc` from 1.58.1 to 1.58.2
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.58.1...v1.58.2)

---
updated-dependencies:
- dependency-name: golang.org/x/mod
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-deps
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-deps
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-deps
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/all-go-deps-d14d9ae022 branch from 3b8468b to 9f7ebf2 Compare October 9, 2023 17:26
@roger2hk
Copy link
Contributor

roger2hk commented Oct 9, 2023

Is it expected to move cloud.google.com/go/cloudsqlconn from an indirect dependency to a direct dependency?

@AlCutter
Copy link
Contributor

AlCutter commented Oct 9, 2023

Is it expected to move cloud.google.com/go/cloudsqlconn from an indirect dependency to a direct dependency?

Yep, looks like it: https://github.com/transparency-dev/distributor/blob/main/cmd/main.go#L28

@AlCutter AlCutter merged commit 403f179 into main Oct 9, 2023
3 checks passed
@AlCutter AlCutter deleted the dependabot/go_modules/all-go-deps-d14d9ae022 branch October 9, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants