Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Page translation" tab doesn't show up when the page finishes loading #353

Open
WofWca opened this issue May 2, 2023 · 1 comment
Open
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@WofWca
Copy link

WofWca commented May 2, 2023

Reproduction

  1. Open some website in a new tab
  2. Before the page finishes loading, click on the extension's icon to open the popup
  3. Only the "text translation" tab should be present at this point, which is (somewhat?) normal.
  4. Wait until the page finishes loading.

Expected behavior: the "Page translation" tab shows up as soon as possible (at least when the page finishes loading)
Actual behavior: the "Page translation" tab doesn't show up. You have to re-open the popup to see it.

Additional info

image

In my extension I have this code that is responsible for waiting for a tab to load (I'm not saying it's ideally written though).

Related: #345, #341

@vitonsky
Copy link
Collaborator

vitonsky commented May 2, 2023

Duplicate of #268

Popup must listen an event that page must emit while loaded, by this event popup must be re-rendered with new tab, but tab must not be changed.

We have to keep id of active tab on the top component, for a smooth implementation of described behavior

@vitonsky vitonsky added bug Something isn't working duplicate This issue or pull request already exists labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants