Updates all npm packages Apr 2024 #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
devinmatte
requested review from
mathcolo,
idreyn,
skaplan-dev and
PatrickCleary
as code owners
|
Okay fixed and pushed to beta |
idreyn
approved these changes
Apr 13, 2024
| @@ -5,7 +5,8 @@ import { OverallRidershipChart } from './OverallRidershipChart'; | |||
|
|
|||
| export const OverallRidershipChartWrapper: React.FC = () => { | |||
| const ridershipData = useRidershipDataLanding(); | |||
| const ridershipDataReady = !ridershipData.isLoading && !ridershipData.isError; | |||
| const ridershipDataReady = | |||
There was a problem hiding this comment.
Not a huge deal but this seems like a bit of regression in the TS definitions of useQuery. Presumably it used to be able to infer data was present because those other two keys are absent, but now it can't?
There was a problem hiding this comment.
Yeah it seems that they now include undefined into the definition of the resulting data object. Which was I think technically possible before but the typescript definition didn't include it. Overall I think this is an improvement although an annoying one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep us up to date with modern software
Changes
Updates all packages to the latest versions and fixes issues from changes
Testing Instructions