Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addWMS() does not hide the attribution when corresponding group is hidden #55

Open
florisvdh opened this issue Feb 27, 2023 · 2 comments
Labels
upstream Bug in upstream repo

Comments

@florisvdh
Copy link

After adding a WMS layer with addWMS(), the attribution display at the bottom is not toggled when the group is shown or hidden respectively. This contrasts with such toggle-behaviour in leaflet::addWMSTiles(), where the attribution is hidden if the group is hidden.

The attached zipped html notebook – leaflet_issue_notebook.nb.html.zip – compares this behaviour between leaflet (first map) and leaflet.extras2 (second map).

I believe leaflet.extras2 should follow the behaviour of leaflet for this.

florisvdh added a commit to inbo/bene-piloot-tvg that referenced this issue Feb 27, 2023
@trafficonese
Copy link
Owner

You're right, but I do think the bug comes from the underlying plugin library.
I will have a deeper look into it, or you could open an Issue here https://github.com/heigeo/leaflet.wms

@trafficonese trafficonese added the upstream Bug in upstream repo label Feb 28, 2023
@trafficonese
Copy link
Owner

heigeo/leaflet.wms#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Bug in upstream repo
Projects
None yet
Development

No branches or pull requests

2 participants