Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove ic_launchers #41

Open
MahdiAstanei opened this issue Dec 9, 2015 · 6 comments
Open

Please remove ic_launchers #41

MahdiAstanei opened this issue Dec 9, 2015 · 6 comments

Comments

@MahdiAstanei
Copy link

the icons in the lib is cause of error:
"Gradle finished with non-zero exit value 1"

@darklordqnct
Copy link

Error:Execution failed for task ':app:processDebugManifest'.

Manifest merger failed : Attribute application@icon value=(@mipmap/ic_launcher) from AndroidManifest.xml:22:9-43
is also present at [com.github.traex.expandablelayout:library:1.2.2] AndroidManifest.xml:13:9-45 value=(@drawable/ic_launcher).
Suggestion: add 'tools:replace="android:icon"' to element at AndroidManifest.xml:19:5-55:19 to override.

@dasheck0
Copy link

+1

You can workaround this by adding replace="android:icon" to the manifest like the following

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    package="....">

    <application
        android:allowBackup="true"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:supportsRtl="true"
        android:theme="@style/AppTheme"
        tools:replace="android:icon"
        >
        ....
    </application>

</manifest>

But as you said it should be there in the first place so please remove it @traex

@teodorpenkov
Copy link

+1

@flyingpic
Copy link

it solved my problem by dasheck0's method

@dasheck0
Copy link

Glad that it helped someone. But as all of us already mentioned it should be removed so that you donÄt need this workaround.

@yanrubi
Copy link

yanrubi commented Dec 30, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants