Feature/react event modal #724
Conversation
src/components/Home/index.js
Outdated
| @@ -49,6 +51,26 @@ export default class Home extends React.Component { | |||
| let totalPromises = 1; | |||
| let numberFinished = 0; | |||
|
|
|||
| let eventId = urlParamsHandler.getUrlParameter('eventId'); | |||
| var stateId = urlParamsHandler.getUrlParameter('state'); | |||
There was a problem hiding this comment.
nit, and I need to update the eslint rules, but can you use const or let instead of var
src/components/Home/index.js
Outdated
| this.setState({ | ||
| selectedTownHall: townhall | ||
| }); | ||
| $('.event-modal').modal('show'); |
There was a problem hiding this comment.
We would like to be able to get rid of jquery, so can you re implement this open functionality? Either just in the component, or use https://ant.design/components/modal/ from the ui library we're using (sorry I should have brought this up when we met before).
| populateEventModal(townhall) | ||
| $('.event-modal').modal('show'); | ||
| if(this.props.selectTownhall) { | ||
| this.props.selectTownhall(townhall); |
There was a problem hiding this comment.
I haven't tried running this locally yet, but I don't see where this is being cleared out. I would think when you close the modal this should go back to null
There was a problem hiding this comment.
It's not, wasn't sure how you would like it, so I'll have it clear on modal close.
| <React.Fragment> | ||
| { | ||
| townhall | ||
| ? <div className="modal fade event-modal" tabIndex="-1" role="dialog" aria-labelledby="myLargeModalLabel"> |
There was a problem hiding this comment.
for this type of check I like townhall && <></> instead of townhall ? <></> : null
| ? <div className="modal fade event-modal" tabIndex="-1" role="dialog" aria-labelledby="myLargeModalLabel"> | |
| && <div className="modal fade event-modal" tabIndex="-1" role="dialog" aria-labelledby="myLargeModalLabel"> |
Description
This fix will convert the event modal over to a react component, and remove the original template code from the application.
Fixes #723