Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig allowJS & eslint all js check #1332

Closed
manudeli opened this issue Oct 20, 2024 · 2 comments
Closed

tsconfig allowJS & eslint all js check #1332

manudeli opened this issue Oct 20, 2024 · 2 comments
Assignees

Comments

@manudeli
Copy link
Member

          I respect your opinion, and I believe that excluding checks for .js files in ESLint settings might be a somewhat regrettable choice. ESLint provides various rules that help maintain code conventions, and these rules still hold significant meaning for files that do not use TypeScript. For example, rules like import/order and prettier can greatly enhance code readability and maintain consistency within the project. From this perspective, I think it is more desirable to apply ESLint checks to all files.

Originally posted by @SEOKKAMONI in #1326 (comment)

Copy link

coauthors bot commented Oct 20, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1332 (comment) #1332 2 Co-authored-by: manudeli <[email protected]>

@manudeli
Copy link
Member Author

@SEOKKAMONI In my opinion, this is not something we must do right now, so I'll close it for now. Feel free to reopen if you think otherwise.

@manudeli manudeli closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants