Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not be switched to in Chrome 51.0.2704.106 (64-bit) on Linux #4

Open
SohanChy opened this issue Jul 21, 2016 · 7 comments
Open

Comments

@SohanChy
Copy link
Contributor

I know this hasn't been updated in a long time but still wondering if you know or have any plans to work on this.
It can not be activated or switched to anymore.

@torifat
Copy link
Owner

torifat commented Jul 21, 2016

I thought people don't use it anymore. We usually tell people to use http://avro.im/ instead.

I will try to have a look at it. But, can't confirm any time because I don't have any Linux box ATM.

@SohanChy
Copy link
Contributor Author

SohanChy commented Jul 22, 2016

So, I looked into it and it does not work in Windows either, because many of the chrome extension api's used in the extension have long been deprecated.
I'm trying to build a new one using the latest api's. Main problem I'm facing is that under the new guidelines you are supposed to turn on and off the script from the background.js, the content.js can not access the chrome.command keyboard shortcuts.
So I think I will have to somehow modify the avro js to make it possible to be toggle-able from outside.

I'm trying to use avropad but I need help,
In the avropad source
if I embed avro.min.js,
Is there any way to call a function to enable and disable avro parsing on a text field?
Like enableAvro($selector,true) to turn on, and enableAvro($selector,false) to turn off?

@torifat

@SohanChy
Copy link
Contributor Author

Scratch that, I've almost fixed it. I got confused because of my very low level of Chrome extension and JS knowledge.
Anyway, I've fixed it.
Will be giving a pull request soon. :)

@SohanChy
Copy link
Contributor Author

Please check the PR and merge if possible.
@torifat

@torifat
Copy link
Owner

torifat commented Jul 25, 2016

@SohanChy Thanks for the pull request. I will do it as soon as I can.

@torifat
Copy link
Owner

torifat commented Jul 25, 2016

Sorry, I was busy with work. So, couldn't reply you in time.

@SohanChy
Copy link
Contributor Author

No problem, I hope you update the version on Chrome store as well. Now me and a bunch of my friends are using this with developer mode on chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants