Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ruby 3.3 and Rails 7.2 to CI matrix #967

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jotolo
Copy link
Contributor

@jotolo jotolo commented Sep 26, 2024

Description

  • Adds Ruby 3.3 to CI matrix.
  • Adds Rails 7.2 Gemfile and tested in CI matrix

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@jotolo jotolo requested a review from a team as a code owner September 26, 2024 07:09
@barthez
Copy link
Contributor

barthez commented Sep 27, 2024

Thank you @jotolo. Let's see the build green and merge.

@jotolo
Copy link
Contributor Author

jotolo commented Sep 27, 2024

Thanks @barthez . Glad to help 🤝

@barthez barthez merged commit 17597e6 into toptal:master Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants