Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up raw sub config types; add note type APIs #57

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Clean up raw sub config types; add note type APIs #57

merged 12 commits into from
Dec 19, 2023

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Sep 25, 2023

Fixes #39. Reworks the types from subConfig.ts into a new set of types for sub config structures and adds a new class, SubredditConfig, which is to the toolbox wiki page as Usernotes is to the usernotes wiki page. Adds methods for looking up user note types and adds examples of how to apply this to display type info for a given usernote.

@eritbh eritbh added the enhancement New feature or request label Sep 25, 2023
@eritbh
Copy link
Member Author

eritbh commented Sep 25, 2023

Couple issues will have to be made when this gets merged

  • I didn't write tests for any of this because I'm a bad developer
  • getAllNoteTypes needs to somehow handle removalReasons.getFrom pointing to reasons from a different subreddit probably. this will require the toolboxclient to be passed to the SubredditConfig constructor so we can fetch config for that second subreddit to look up its notes and that will suck
    • i dont know what i was thinking when i wrote this, that's a removal reasons thing and has nothing to do with usernote types. but this will have to be handled somehow later when we start doing removal reasons

@eritbh
Copy link
Member Author

eritbh commented Dec 19, 2023

we ball

@eritbh eritbh merged commit 7b83797 into main Dec 19, 2023
1 check passed
@eritbh eritbh deleted the feat/config branch December 19, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subreddit config: Usernote types
1 participant