Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Toolbox working in sh.reddit #864

Open
eritbh opened this issue Nov 14, 2023 · 1 comment
Open

Get Toolbox working in sh.reddit #864

eritbh opened this issue Nov 14, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@eritbh
Copy link
Member

eritbh commented Nov 14, 2023

The end goal here would be to get feature parity between "new new Reddit" (sh.reddit.com) and "new Reddit" (new.reddit.com, except as of recently that apparently also shows the sh.reddit design now). This would not implement features that are currently exclusive to old Reddit, only the ones that are currently available on new Reddit.

Implementation-wise, this will be like the oldreddit module, emulating jsAPI events and creating slot containers for buttons and stuff to go. This is gonna suck a lot more than writing the oldreddit module though given the architecture of sh.reddit.

@eritbh eritbh added the enhancement New feature or request label Nov 14, 2023
@eritbh eritbh changed the title sh.reddit jsAPI shim Get Toolbox working in sh.reddit via a jsAPI shim Feb 9, 2024
@eritbh eritbh added this to the v7 milestone Mar 24, 2024
@eritbh
Copy link
Member Author

eritbh commented Jun 9, 2024

Scope here has changed significantly - this mostly just relies on #865 now. That issue covers the new system for frontend slots and frontend observers, and their parity with the old implementation on existing frontends; this issue covers the subsequent creation of the shreddit frontend observer to get things working on shreddit.

@eritbh eritbh changed the title Get Toolbox working in sh.reddit via a jsAPI shim Get Toolbox working in sh.reddit Jun 9, 2024
@eritbh eritbh pinned this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant