Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow isotp implementation per mailbox #59

Open
david-res opened this issue Jan 3, 2023 · 2 comments
Open

Allow isotp implementation per mailbox #59

david-res opened this issue Jan 3, 2023 · 2 comments

Comments

@david-res
Copy link

Is there any way that I can assign an isotp callback to a mailbox filter?
Similar to how I would assign a custom callback per mailbox?
Could this capability be developed?

I am making requests to multiple nodes, and while two of them always have the same ID and can retain the same set of callbacks/response code, one of them (the ECU) varies with up to six different response parsing options and would be easier for me to manage if I can isolate the response logic into separate callbacks per node, as at the moment everything is in one isotp callback, and I need to copy the entire logic between each ECU variant which is prone to mistakes and is taking up memory

@david-res david-res changed the title Allow isoTP implementation per mailbox Allow isotp implementation per mailbox Jan 3, 2023
@tonton81
Copy link
Owner

per mailbox? not in it's current form, the fixed buffer is a collector of all mailboxes. it would require a rewrite of most of the code to do this

@david-res
Copy link
Author

Got it.
So ideally a smaller user defined iso tp buffer per MB would be ideal for me.
It just makes it easier code wise to reconfig the mb callback/buffer rather than having to maintain multiple versions of the isotp rx callback that contain handlers for multiple IDs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants