Paypal payment method #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this PR has a commit from another outstanding PR, but this change needed to rename a file contained in that commit. Hard to explain. Sorry.
Anyway, this PR basically defines a new PaymentMethod for use with PayPal. The reason this was needed is because somewhere along the way (maybe the Spree 1.0 release?) the IPN notifications stopped working. I traced it back to the fact that order state transitions in the
Spree::PaymentNotificationsControllerwere failing. The reason was that the order's payment source was nil, but in order to process the payment Spree required a payment source. This was becauseSpree::PaymentSource#source_required?method is hard-codingtrue. This new payment method I created is basically a dummy payment method that can be used when configuring the PayPal payment method in the admin interface. It simply returnsfalsein thesource_required?method.