Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move infra modules to core #9207

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 19, 2024

No description provided.

Copy link
Member Author

EYHN commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app test Related to test cases app:core labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (2ea79d2) to head (129f94e).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ges/frontend/core/src/modules/db/entities/table.ts 0.00% 3 Missing ⚠️
...ackages/frontend/core/src/modules/storage/index.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9207      +/-   ##
==========================================
- Coverage   52.04%   51.82%   -0.22%     
==========================================
  Files        2127     2119       -8     
  Lines       97453    97407      -46     
  Branches    16673    16666       -7     
==========================================
- Hits        50715    50477     -238     
- Misses      45344    45560     +216     
+ Partials     1394     1370      -24     
Flag Coverage Δ
server-test 78.26% <ø> (ø)
unittest 30.85% <14.28%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/refactor/infra-modules branch from 2130247 to 275c243 Compare December 20, 2024 07:41
@EYHN EYHN marked this pull request as ready for review December 20, 2024 07:41
@EYHN EYHN force-pushed the eyhn/refactor/infra-modules branch from 275c243 to 5adf76a Compare December 20, 2024 07:46
@EYHN EYHN changed the base branch from eyhn/feat/worker to graphite-base/9207 December 20, 2024 08:01
@EYHN EYHN force-pushed the eyhn/refactor/infra-modules branch from 5adf76a to 5530a3c Compare December 20, 2024 08:05
@EYHN EYHN force-pushed the graphite-base/9207 branch from 3c9f641 to cbaf35d Compare December 20, 2024 08:05
@EYHN EYHN changed the base branch from graphite-base/9207 to canary December 20, 2024 08:17
@EYHN EYHN force-pushed the eyhn/refactor/infra-modules branch 4 times, most recently from ced514e to 761734e Compare December 23, 2024 03:53
Copy link

graphite-app bot commented Dec 23, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/refactor/infra-modules branch from 761734e to 129f94e Compare December 23, 2024 04:54
@graphite-app graphite-app bot merged commit 129f94e into canary Dec 23, 2024
60 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/infra-modules branch December 23, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants