From d83164dbd5887327c331372c470ff1b10c5708a4 Mon Sep 17 00:00:00 2001
From: Peng Xiao <pengxiao@outlook.com>
Date: Thu, 7 Nov 2024 11:50:50 +0800
Subject: [PATCH] fix(core): setting height issue

---
 .../frontend/core/src/desktop/dialogs/setting/style.css.ts  | 1 +
 .../core/src/modules/open-in-app/views/open-in-app-page.tsx | 6 ++----
 packages/frontend/i18n/src/i18n-completenesses.json         | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/packages/frontend/core/src/desktop/dialogs/setting/style.css.ts b/packages/frontend/core/src/desktop/dialogs/setting/style.css.ts
index 2fc1c79ccd4b3..9543873d4fe12 100644
--- a/packages/frontend/core/src/desktop/dialogs/setting/style.css.ts
+++ b/packages/frontend/core/src/desktop/dialogs/setting/style.css.ts
@@ -10,6 +10,7 @@ export const centerContainer = style({
   display: 'flex',
   flexDirection: 'column',
   alignItems: 'center',
+  height: 'fit-content',
 });
 export const content = style({
   position: 'relative',
diff --git a/packages/frontend/core/src/modules/open-in-app/views/open-in-app-page.tsx b/packages/frontend/core/src/modules/open-in-app/views/open-in-app-page.tsx
index 8dc178e103138..ceb317b31560f 100644
--- a/packages/frontend/core/src/modules/open-in-app/views/open-in-app-page.tsx
+++ b/packages/frontend/core/src/modules/open-in-app/views/open-in-app-page.tsx
@@ -151,14 +151,12 @@ export const OpenInAppPage = ({ urlToOpen, openHereClicked }: OpenAppProps) => {
 
       {maybeDocLink ? (
         <div className={styles.docFooter}>
-          <a
+          <button
             className={styles.editSettingsLink}
             onClick={goToAppearanceSetting}
-            target="_blank"
-            rel="noreferrer"
           >
             {t['com.affine.auth.open.affine.doc.edit-settings']()}
-          </a>
+          </button>
 
           <div className={styles.docFooterText}>
             <LocalWorkspaceIcon width={16} height={16} />
diff --git a/packages/frontend/i18n/src/i18n-completenesses.json b/packages/frontend/i18n/src/i18n-completenesses.json
index 24ef0923c0120..7841a58857092 100644
--- a/packages/frontend/i18n/src/i18n-completenesses.json
+++ b/packages/frontend/i18n/src/i18n-completenesses.json
@@ -10,7 +10,7 @@
   "fr": 71,
   "hi": 2,
   "it": 1,
-  "ja": 95,
+  "ja": 94,
   "ko": 84,
   "pl": 0,
   "pt-BR": 91,