From b8cb504fa4f9428ad6218c4e25a84318273a3857 Mon Sep 17 00:00:00 2001 From: EYHN Date: Tue, 22 Oct 2024 04:55:05 +0000 Subject: [PATCH] feat(core): adjust app sidebar (#8572) --- .../src/modules/app-sidebar/views/index.tsx | 19 +------------------ .../i18n/src/i18n-completenesses.json | 2 +- 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/packages/frontend/core/src/modules/app-sidebar/views/index.tsx b/packages/frontend/core/src/modules/app-sidebar/views/index.tsx index 28dc9027f8497..b419f49a9bb83 100644 --- a/packages/frontend/core/src/modules/app-sidebar/views/index.tsx +++ b/packages/frontend/core/src/modules/app-sidebar/views/index.tsx @@ -48,7 +48,6 @@ export function AppSidebar({ children }: PropsWithChildren) { const smallScreenMode = useLiveData(appSidebarService.smallScreenMode$); const hovering = useLiveData(appSidebarService.hovering$) && open !== true; const resizing = useLiveData(appSidebarService.resizing$); - const [deferredHovering, setDeferredHovering] = useState(false); const [initialized, setInitialized] = useState(false); useEffect(() => { @@ -65,29 +64,13 @@ export function AppSidebar({ children }: PropsWithChildren) { // eslint-disable-next-line react-hooks/exhaustive-deps }, []); - useEffect(() => { - if (open) { - // if open, we don't need to show the floating sidebar - setDeferredHovering(false); - return; - } - // we make a little delay here. - // this allow the sidebar close animation to complete. - const timeout = setTimeout(() => { - setDeferredHovering(hovering); - }, 150); - return () => { - clearTimeout(timeout); - }; - }, [hovering, open]); - const sidebarState = smallScreenMode ? open ? 'floating-with-mask' : 'close' : open ? 'open' - : deferredHovering + : hovering ? 'floating' : 'close'; diff --git a/packages/frontend/i18n/src/i18n-completenesses.json b/packages/frontend/i18n/src/i18n-completenesses.json index faee20552e987..0ff53acc0a1a9 100644 --- a/packages/frontend/i18n/src/i18n-completenesses.json +++ b/packages/frontend/i18n/src/i18n-completenesses.json @@ -10,7 +10,7 @@ "fr": 77, "hi": 2, "it": 1, - "ja": 75, + "ja": 100, "ko": 91, "pl": 0, "pt-BR": 99,