Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1860 - player values and liquidity values glitch #11332

Open
vantdog opened this issue Nov 9, 2024 · 5 comments · May be fixed by #11340
Open

1860 - player values and liquidity values glitch #11332

vantdog opened this issue Nov 9, 2024 · 5 comments · May be fixed by #11340
Assignees
Labels
1860 game UI In game UI

Comments

@vantdog
Copy link

vantdog commented Nov 9, 2024

What's your Game ID?

How to Reproduce the Bug?

Which Browser / Platform?

@vantdog
Copy link
Author

vantdog commented Nov 9, 2024

Game ID - https://18xx.games/game/185628

player values and liquidity numbers have been wrong all game. Check spreadsheet and game log. Glitch with this variant?

persisted to the end https://18xx.games/game/185628

@vantdog vantdog changed the title 1860 1860 - player values and liquidity values glitch Nov 9, 2024
@vantdog
Copy link
Author

vantdog commented Nov 9, 2024

This game too - https://18xx.games/game/183959

also has the same variant in use . .

@roseundy
Copy link
Collaborator

@philcampeau did you adjust the liquidity calculations when you implemented this variant?

@roseundy roseundy assigned roseundy and philcampeau and unassigned roseundy Nov 10, 2024
@philcampeau
Copy link
Collaborator

I did, but apparently goofed the calculation. I'll take a look this afternoon.

@philcampeau philcampeau added 1860 game UI In game UI and removed needs triage labels Nov 11, 2024
@philcampeau
Copy link
Collaborator

Oh derp. I forgot to add in the value of the shares of corps with trains. That's pretty significant!

Fix incoming.

@philcampeau philcampeau linked a pull request Nov 11, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1860 game UI In game UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants