Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update URL mapping and add advprop pretrain models #111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

update URL mapping and add advprop pretrain models #111

wants to merge 5 commits into from

Conversation

Cyril9227
Copy link

@Cyril9227 Cyril9227 commented Jan 28, 2020

@toandaominh1997 thank's for your amazing work.

However the URL links are broken, this PR fixes the URL mapping and also provides the option to load pretrained models using adversarial training, called advprop, see luke melas implementation.

Also modified docstrings and comments in efficientnet.py so they reflect better what the code is actually doing (it was previously a copy paste from another repo) and made few changes so the code stay consistent with the new available weights.

The project should be operational with those changes.

@pep8speaks
Copy link

pep8speaks commented Jan 28, 2020

Hello @Cyril9227! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 49:1: W293 blank line contains whitespace
Line 180:80: E501 line too long (82 > 79 characters)
Line 194:80: E501 line too long (88 > 79 characters)
Line 216:80: E501 line too long (121 > 79 characters)
Line 228:80: E501 line too long (89 > 79 characters)
Line 250:68: W291 trailing whitespace

Line 307:80: E501 line too long (110 > 79 characters)
Line 308:80: E501 line too long (110 > 79 characters)
Line 309:80: E501 line too long (110 > 79 characters)
Line 310:80: E501 line too long (110 > 79 characters)
Line 311:80: E501 line too long (110 > 79 characters)
Line 312:80: E501 line too long (110 > 79 characters)
Line 313:80: E501 line too long (110 > 79 characters)
Line 314:80: E501 line too long (110 > 79 characters)
Line 319:80: E501 line too long (115 > 79 characters)
Line 319:116: W291 trailing whitespace
Line 320:80: E501 line too long (115 > 79 characters)
Line 321:80: E501 line too long (115 > 79 characters)
Line 322:80: E501 line too long (115 > 79 characters)
Line 323:80: E501 line too long (115 > 79 characters)
Line 324:80: E501 line too long (115 > 79 characters)
Line 325:80: E501 line too long (115 > 79 characters)
Line 326:80: E501 line too long (115 > 79 characters)
Line 327:80: E501 line too long (115 > 79 characters)
Line 342:80: E501 line too long (107 > 79 characters)

Comment last updated at 2020-01-28 07:51:51 UTC

Removed duplicate function from_pretrained and added advprop option to from_pretrained function
Modified docstrings and comments so they reflect better what the code is actually doing (it was previously a copy paste from another repo) and made few changes so the code stay consistent with the new available weights
@JVGD
Copy link

JVGD commented Apr 24, 2020

Please merge this, I am having the same problem.
By the way, thank you @Cyril9227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants