Skip to content

Commit

Permalink
Added missing remote offline store apis implementation
Browse files Browse the repository at this point in the history
Signed-off-by: Theodor Mihalache <[email protected]>
  • Loading branch information
tmihalac committed Jun 4, 2024
1 parent f3f44c3 commit cf38149
Show file tree
Hide file tree
Showing 7 changed files with 537 additions and 164 deletions.
5 changes: 5 additions & 0 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,11 @@ def create_saved_dataset(
dataset.min_event_timestamp = from_.metadata.min_event_timestamp
dataset.max_event_timestamp = from_.metadata.max_event_timestamp

# Added to handle the case that the offline store is remote
self._registry.apply_data_source(
storage.to_data_source(), self.project, commit=True
)

from_.persist(storage=storage, allow_overwrite=allow_overwrite)

dataset = dataset.with_retrieval_job(
Expand Down
Loading

0 comments on commit cf38149

Please sign in to comment.