Fixed client issue of not being able to specify the notary url path #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuroitaki
requested changes
Oct 1, 2024
…ell as extend the path calculation to avoid adding a `/` when already starts with a `/`
…ell as extend the path calculation to avoid adding a `/` when already starts with a `/`
…o fix/allow-url-path-for-notary
yuroitaki
requested changes
Oct 1, 2024
Co-authored-by: yuroitaki <[email protected]>
…o fix/allow-url-path-for-notary
yuroitaki
approved these changes
Oct 3, 2024
|
@ElusAegis the formatting ci failed, can you follow the instructions here? https://github.com/tlsnotary/tlsn/blob/dev/CONTRIBUTING.md#pull-requests |
ElusAegis
changed the title
|
@yuroitaki please have a look - I have fixed the formatting |
Merged! Thanks for your help~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue #612
Add an optional configuration
pathto theNotaryClientstructure, to supliment the existingportandhost. Defaults to empty String.