Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TLS and Authorization Configuration Fields Optional #589

Merged
merged 12 commits into from
Nov 22, 2024

Conversation

yorozunouchu
Copy link

This pull request fixes #565 where the TLSNotary server fails to start when specific configuration fields (private_key_pem_path, certificate_pem_path, and whitelist_csv_path) are missing, even when the corresponding features are disabled.

Please review and provide feedback!

@yuroitaki yuroitaki self-requested a review September 19, 2024 06:33
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR guys! Few comments, and also

  • base your PR on dev instead of main
  • remember to follow the guideline here

notary/server/src/error.rs Outdated Show resolved Hide resolved
notary/server/src/main.rs Outdated Show resolved Hide resolved
notary/server/src/server.rs Outdated Show resolved Hide resolved
notary/server/src/server.rs Outdated Show resolved Hide resolved
notary/server/src/server.rs Outdated Show resolved Hide resolved
notary/server/src/server.rs Outdated Show resolved Hide resolved
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to base your PR on dev instead of main~

crates/notary/server/src/server.rs Outdated Show resolved Hide resolved
@yorozunouchu yorozunouchu changed the base branch from main to dev October 31, 2024 10:49
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.43%. Comparing base (c10c915) to head (9662f70).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/notary/server/src/server.rs 87.09% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #589   +/-   ##
=======================================
  Coverage   55.43%   55.43%           
=======================================
  Files         193      193           
  Lines       20842    20853   +11     
=======================================
+ Hits        11553    11560    +7     
- Misses       9289     9293    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yuroitaki
Copy link
Member

@yorozunouchu the CI fails because of clippy and formatting; can you guys follow the guidelines here https://github.com/tlsnotary/tlsn/blob/dev/CONTRIBUTING.md#linting and https://github.com/tlsnotary/tlsn/blob/dev/CONTRIBUTING.md#style

Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks so much again @yorozunouchu and @funkyenough !

@yuroitaki yuroitaki merged commit 7d88d1c into tlsnotary:dev Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLSNotary server wont start without private-key-pem-path defined even when its unused
3 participants