-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TLS and Authorization Configuration Fields Optional #589
Make TLS and Authorization Configuration Fields Optional #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR guys! Few comments, and also
- base your PR on dev instead of main
- remember to follow the guideline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to base your PR on dev instead of main~
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #589 +/- ##
=======================================
Coverage 55.43% 55.43%
=======================================
Files 193 193
Lines 20842 20853 +11
=======================================
+ Hits 11553 11560 +7
- Misses 9289 9293 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@yorozunouchu the CI fails because of clippy and formatting; can you guys follow the guidelines here https://github.com/tlsnotary/tlsn/blob/dev/CONTRIBUTING.md#linting and https://github.com/tlsnotary/tlsn/blob/dev/CONTRIBUTING.md#style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks so much again @yorozunouchu and @funkyenough !
This pull request fixes #565 where the TLSNotary server fails to start when specific configuration fields (
private_key_pem_path
,certificate_pem_path
, andwhitelist_csv_path
) are missing, even when the corresponding features are disabled.Please review and provide feedback!