Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): remove examples, fix bug #585

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Sep 11, 2024

This PR fixes a bug introduced in #573 and also gets rid of examples which are not easily testable.

@heeckhau
Copy link
Member

@sinui0 I restored the Discord example:

I tested the Discord example and it runs fine on my machine™️

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep the Discord example for now

@sinui0 sinui0 merged commit 67dc7c8 into dev Sep 12, 2024
5 checks passed
@sinui0 sinui0 deleted the chore/delete-examples branch September 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants