Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate chrome driver failure in wasm test #576

Open
th4s opened this issue Aug 30, 2024 · 6 comments
Open

Investigate chrome driver failure in wasm test #576

th4s opened this issue Aug 30, 2024 · 6 comments

Comments

@th4s
Copy link
Member

th4s commented Aug 30, 2024

We should make sure that we understand what happened here:

https://github.com/tlsnotary/tlsn/actions/runs/10628828020/job/29464418444

@themighty1
Copy link
Member

The actual error is a 404 for http://127.0.0.1:8013/favicon.ico
We may want to whitelist "favicon.ico" and not treat its absence as an error.

@heeckhau
Copy link
Member

heeckhau commented Sep 9, 2024

The 404 is not the reason the test fails; it fails because of a timeout.

local run:

2024-09-09T10:02:59.619976Z ERROR tlsn_wasm_test_runner::chrome_driver: LogEntry { source: Network, level: Error, text: "Failed to load resource: the server responded with a status of 404 (Not Found)", category: None, timestamp: Timestamp(1725876179619.673), url: Some("http://127.0.0.1:8013/favicon.ico"), line_number: None, stack_trace: None, network_request_id: Some(RequestId("89790.5")), worker_id: None, args: None }
test_notarize: passed
test_prove: passed
test_verifier: passed
3 passed, 0 failed

linked job output:

2024-08-30T07:51:06.504671Z  WARN run: chromiumoxide::browser: Browser was not closed manually, it will be killed automatically in the background
Error: Request timed out.
Error: Process completed with exit code 1.

@heeckhau
Copy link
Member

heeckhau commented Oct 3, 2024

@themighty1 This is still happening on alpha.7 from time to time: e.g.: https://github.com/tlsnotary/tlsn/actions/runs/11155476995/job/31006466036?pr=617

:48:21.975010Z  INFO start: tlsn_wasm_test_runner::wasm_server: listening on 127.0.0.1:8013
2024-10-03T03:48:21.975063Z  INFO start: tlsn_wasm_test_runner::ws: listening on: 127.0.0.1:8080
2024-10-03T03:48:21.975154Z  INFO start: tlsn_wasm_test_runner::server_fixture: listening on: 127.0.0.1:8083
2024-10-03T03:48:21.975450Z DEBUG run: tlsn_wasm_test_runner::chrome_driver: launching chromedriver
2024-10-03T03:48:26.546524Z DEBUG run: tungstenite::handshake::client: Client handshake done.    
2024-10-03T03:48:26.546[688](https://github.com/tlsnotary/tlsn/actions/runs/11155476995/job/31006466036?pr=617#step:8:689)Z DEBUG run: tlsn_wasm_test_runner::chrome_driver: chromedriver started
2024-10-03T03:50:26.546823Z  WARN run: chromiumoxide::browser: Browser was not closed manually, it will be killed automatically in the background
Error: Request timed out.
Error: Process completed with exit code 1.

BTW: Is this the same error as what went wrong with the browser benchmarks?

@themighty1
Copy link
Member

@heeckhau , nope, i dont see any familiar errors. But this may indicate some wonkiness with chromiumoxide.

@themighty1
Copy link
Member

@heeckhau Are you suggesting that this error still persists even after we added .incognito() ? https://github.com/tlsnotary/tlsn/blame/4d5102b6e141ecb84b8a835604be1d285ae6eaa5/crates/wasm-test-runner/src/chrome_driver.rs#L19

@heeckhau
Copy link
Member

Yes, there must still be a race somewhere.
Sometimes the was tests still fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants