Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az-acr: add page #10912

Merged
merged 6 commits into from
Oct 11, 2023
Merged

az-acr: add page #10912

merged 6 commits into from
Oct 11, 2023

Conversation

BS14
Copy link
Contributor

@BS14 BS14 commented Oct 9, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

For: #6141

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 9, 2023
@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BS14 Welcome to tldr and thanks for your contribution. Can you sign the CLA for this PR to go through?

@BS14
Copy link
Contributor Author

BS14 commented Oct 10, 2023

@kbdharun I have already signed CLA. Not sure why it is not being reflected in the checks. Any idea on this ?

image
image

@kbdharun
Copy link
Member

kbdharun commented Oct 10, 2023

@kbdharun I have already signed CLA. Not sure why it is not being reflected in the checks. Any idea on this ?

Screenshot from 2023-10-10 10-47-50

I can confirm you have signed the CLA (checked it in the admin interface). But seems like the commits you made don't have the same email address as your GitHub account/your email isn't configured locally. Feel free to try out these steps https://github.com/tldr-pages/tldr/blob/main/contributing-guides/git-terminal.md#changing-the-email-of-any-commits after setting the name and email globally using:

git config --global user.name "Your name"
git config --global user.email "[email protected]"

@BS14
Copy link
Contributor Author

BS14 commented Oct 10, 2023

@kbdharun Ready to merge. Thank you for guidance.

pages/common/az-acr.md Outdated Show resolved Hide resolved
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@gutjuri gutjuri merged commit 05ef9b0 into tldr-pages:main Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants