Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple recipients don't display correctly in Android #35

Open
levibotelho opened this issue Nov 18, 2017 · 8 comments
Open

Multiple recipients don't display correctly in Android #35

levibotelho opened this issue Nov 18, 2017 · 8 comments

Comments

@levibotelho
Copy link

Not sure if this is a problem with Android or the lib, but figured I'd bring this up.

If I create an SMS to two recipients in Android, my screen looks like this:

image

However if I create an SMS to two recipients via the lib, I get this:

image

Notice how only the last recipient is shown. This is what the "People & Options" menu looks like:

image

It appears that both numbers are being added (hence the block text) but that only the last is taken into account (hence the "people in this conversation" list). I'm not testing this on an actual device yet so I don't know if it's just a display issue or if the SMS will actually only be sent to the second recipient, but at the very least this could be confusing for the user from a UX standpoint.

@levibotelho
Copy link
Author

Looking a bit more deeply into this it might be due to the device I'm on (Pixel 1 emulator). Not sure if it just requires a comma separator or if it's simply not possible on this device. Can investigate further if you want help...

@tkporter
Copy link
Owner

Hi @levibotelho, were you able to find a potential solution or reason for this behavior?

@levibotelho
Copy link
Author

levibotelho commented Jan 12, 2018

No. Poked around a bit and might just have to live with it... might be a device-dependent thing...

@Gazfay
Copy link

Gazfay commented Oct 31, 2018

Have the same problem with devices on android 8.

@dancherb
Copy link

@Gazfay Just saw that you hooray'd my post - I'm actually reporting that there's still a bug: when you send a message to multiple recipients, the "success" status doesn't go through and you just get "cancelled" when you return to the app. (I'll delete previous replies for clarity.)

@ashleypeacock
Copy link

Tried this on Nexus 6 and Pixel 2 XL emulator and it can't take multiple recipients.

String separator = ";";
                if(android.os.Build.MANUFACTURER.equalsIgnoreCase("Samsung")){
                    separator = ",";
                }

is the issue. To work the deliminator needs to be a "," instead of a semi-colon.

Code works fine on Nokia 7 device.

@tkporter
Copy link
Owner

tkporter commented Feb 6, 2020

@ashleypeacock nice find! Would you be able to open up a PR with that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants