Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawSight rectangle bug #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

drawSight rectangle bug #29

wants to merge 2 commits into from

Conversation

comur
Copy link

@comur comur commented Jul 9, 2015

Hi,

I guess you commented the rectangle part of your code because it wasn't in the middle of the screen (i saw when i uncommented).
I changed a few things to make it work. If it's ok for you, you can just merge.

Anyway thanks for this great work !

Hi,

I guess you commented the rectangle part of your code because it wasn't in the middle of the screen (i saw when i uncommented).
I changed a few things to make it work. If it's ok for you, you can just merge.

Anyway thanks for this great work !
@dcousens
Copy link
Contributor

@comur can you post a screenshot of the differences? This doesn't look like a bug to me, just a change in what was the original behaviour.

@dcousens
Copy link
Contributor

Needs rebase and waiting on @comur's response of screenshots

@dcousens dcousens self-assigned this Jul 29, 2016
@comur
Copy link
Author

comur commented Jul 29, 2016

Hi @dcousens

I don't have possibility to make screenshots right now but I can explain you the differences pretty easily

Before:

I had vertical a red line horizontally centered not side to side but in the middle of the screen (maybe 80% long)
I did not have any rectangle at all

After:

Actually I have a white rectangle in the middle of the screen
I have horizontal red line vertically centered in the white rectangle

For me it was the expected behavior to have a white rectangle with a red line inside, if it is not, maybe it can be an optional parameter ?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants