Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Club announcements #1724

Merged
merged 42 commits into from
Oct 6, 2024
Merged

Club announcements #1724

merged 42 commits into from
Oct 6, 2024

Conversation

JasonGrace2282
Copy link
Member

Supersedes #1647

krishnans2006 and others added 18 commits October 1, 2024 20:27
@krishnans2006 @JasonGrace2282
feat(announcements): implement models/UI for club announcements
7d0a636
@krishnans2006 @JasonGrace2282
feat(announcements): animate club announcements on dashboard
ca4ddd4
@krishnans2006 @JasonGrace2282
feat(announcements): filter club announcements by subscription status
94777f4 
also fix subscribe/unsubscribe button styling
@alanzhu0 @JasonGrace2282
refactor: update year on search, announcement request pages
9353de5
@alanzhu0 @JasonGrace2282
refactor(announcements): reword guidelines and remove redundant code
d50a7eb
@alanzhu0 @JasonGrace2282
perf(announcements): add prefetch query in status view and tighten perms
790c928 
Greatly reduces load time
@alanzhu0 @JasonGrace2282
feat(announcements): continue adding functionality and permissions
ff65c64
@krishnans2006 @JasonGrace2282
style(announcements): dark theme fixes
ae02f8d
@krishnans2006 @JasonGrace2282
fix(announcements): handle some edge cases
4246911
@krishnans2006 @JasonGrace2282
style(announcements): improve club announcement form
b6e91d7
@krishnans2006 @JasonGrace2282
feat(eighth): add subscribe and unsubscribe buttons everywhere
347047f
@krishnans2006 @JasonGrace2282
feat(eighth): add activity settings page for club announcements control
d548e8a
@krishnans2006 @JasonGrace2282
fix: format and build sources
6b3147d
@alanzhu0 @JasonGrace2282
fix(eighth): fix club announcements settings back button
b7c7712
@alanzhu0 @JasonGrace2282
refactor(announcements): text changes
e2f9673
@krishnans2006 @JasonGrace2282
fix: format code, build sources, build docs
d8a39b4
@shrysjain @JasonGrace2282
fix: add club ann. text and remove hoco banner for ann. pages
07c6d70
@JasonGrace2282
fix: invalid button logic for dashboard
60872bb
@shrysjain
Copy link
Member

shrysjain commented Oct 2, 2024 •
edited
Loading

Copying over the to-do list

  • Archive club announcements
  • Search club announcements
  • Restrict subscriptions for restricted activities to only those on the authorized list
  • Force club sponsors to be subscribed to announcements
  • Rewrite intranet/apps/eighth/views/activities.py, lines 60-64 and intranet/templates/eighth/take_attendance.html, line 500 to allow both the eighth activity sponsors and the club announcements sponsors to edit settings
  • Apparently add tests along the way (unfortunate)
  • Remove the homecoming banner from the club announcements page
  • For this text on the request post page: "Want to post an announcement for your club's members? Submit a club announcement instead!" add it for club sponsors as well (currently only for club officers)
  • intranet/templates/dashboard/dashboard.html show the announcement banner to everyone (not just officers/sponsors)

@JasonGrace2282
Copy link
Member Author

JasonGrace2282 commented Oct 2, 2024 •
edited
Loading

There's currently a bug where club announcements for non-subscribed users are not showing... I'm working on it now. EDIT: Fixed

Otherwise, @shrysjain, I finished the "archive view" (which is just a show all button). If you have any feedback on it just lmk.

@JasonGrace2282
feat: implement "other club announcements" filter
8d4abda 
Also adds typehints/docstrings to helper functions.
@JasonGrace2282 JasonGrace2282 mentioned this pull request Oct 3, 2024
Draft
@JasonGrace2282
Copy link
Member Author

JasonGrace2282 commented Oct 4, 2024 •
edited
Loading

With help from @UsernameDP a basic search feature is now complete.

@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review October 5, 2024 05:31
@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner October 5, 2024 05:31
@alanzhu0 alanzhu0 force-pushed the club-announcements branch 2 times, most recently from b387769 to 92483f1 Compare October 5, 2024 06:22
@alanzhu0 alanzhu0 force-pushed the club-announcements branch from 92483f1 to f64049b Compare October 5, 2024 06:34
@alanzhu0 alanzhu0 merged commit 5fa219a into tjcsl:dev Oct 6, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonGrace2282 @shrysjain @alanzhu0 @krishnans2006