-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New club announcements PR (and some other things added in) #1647
Draft
alanzhu0
wants to merge
17
commits into
tjcsl:dev
Choose a base branch
from
alanzhu0:alan-club-announcements
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanzhu0
force-pushed
the
alan-club-announcements
branch
4 times, most recently
from
April 1, 2024 02:34
b4bca0e
to
56ea8f3
Compare
alanzhu0
force-pushed
the
alan-club-announcements
branch
from
April 6, 2024 05:14
56ea8f3
to
157923b
Compare
also fix subscribe/unsubscribe button styling
Greatly reduces load time
krishnans2006
force-pushed
the
alan-club-announcements
branch
from
April 7, 2024 22:56
157923b
to
62a9f8a
Compare
If you want to contribute to this PR, ask me for push access to the branch or rebase off this branch on your own fork. |
Club announcements features left to add:
|
Also (small things):
|
Also add tests along the way :) |
new: force sponsors to be subscribed to announcements |
Merged
Development has now moved to #1724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off #1617