You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The page range option on the Ion printing page does not clearly describe the possible ways to represent the range.
For example, it might be intuitive for some people that to get the first 3 pages the page range might be 0-3, but pages
aren't zero indexed. Furthuremore, Ion only gives the vague error message of an invalid page range, which doesn't tell the user if it was a parsing issue, or an out of bounds issue, or something else.
Topic of discussion
The page range option on the Ion printing page does not clearly describe the possible ways to represent the range.
For example, it might be intuitive for some people that to get the first 3 pages the page range might be
0-3
, but pagesaren't zero indexed. Furthuremore, Ion only gives the vague error message of an invalid page range, which doesn't tell the user if it was a parsing issue, or an out of bounds issue, or something else.
Proposed options/solutions
Rewrite
check_page_range
ion/intranet/apps/printing/views.py
Line 244 in 8cb7791
to return more descriptive errors (instead of returning
None
), and maybe add ahelp_text
for the page range option.Whatever behavior is added/changed should also be tested thoroughly.
Personal opinion (if applicable)
This is probably a good first issue for contributors.
It also might be worth considering making the
check_page_range
function a form field validator and/or overridingForm.clean
- see https://docs.djangoproject.com/en/4.2/ref/forms/validation/The text was updated successfully, but these errors were encountered: