Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-3307: Update storybook to use v8 and Vite builder #55

Merged
merged 8 commits into from
Jun 13, 2024
Merged

INT-3307: Update storybook to use v8 and Vite builder #55

merged 8 commits into from
Jun 13, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Jun 11, 2024 •
edited
Loading

Ticket: INT-3307

Changes:

  • Removed unused storybook addons
  • Updated storybook related dependencies to v8
  • Added user controls to the storybooks
  • deploy-storybook now uses gh-pages package
  • .storybook/*.js files renamed to typescipt

@danoaky-tiny danoaky-tiny marked this pull request as ready for review June 11, 2024 07:03
@danoaky-tiny danoaky-tiny requested a review from a team as a code owner June 11, 2024 07:03
@danoaky-tiny danoaky-tiny requested review from spocke, TheSpyder, hamza0867, ltrouton, a team, kemister85, jscasca, lorenzo-pomili, MitchC1999, shanmen-tiny and tiny-ben-tran and removed request for a team June 11, 2024 07:03
kemister85
kemister85 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • verified yarn storybook builds, and no console errors.

@danoaky-tiny danoaky-tiny merged commit 016ef7b into main Jun 13, 2024
4 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3307 branch June 17, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmen-tiny shanmen-tiny shanmen-tiny approved these changes

@kemister85 kemister85 kemister85 approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton

@jscasca jscasca Awaiting requested review from jscasca

@lorenzo-pomili lorenzo-pomili Awaiting requested review from lorenzo-pomili

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danoaky-tiny @kemister85 @shanmen-tiny