-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Define and implement Provider interface for providers package #5
Labels
enhancement
New feature or request
Comments
This will need many more dedicated issues to address and meet the desired outcome in smaller steps. |
Cool |
raamsri
added a commit
that referenced
this issue
Oct 6, 2024
This commit lays the ground work for fetching multi-provider API data by the interface methods that every provider must implement. It also includes the logic to set log level, which I couldn't pull out as a separate commit. And, an HTTPClient interface signature change. - Implement Provider interface for open-meteo.com - Placeholders for meteoblue.com - Unmarshals the data onto plumber.BaseData struct - Return HTTPClient for HTTPClient.NewRequest() method so that client methods can be chained as resty natively does. #5 #2 Signed-off-by: Raamsri Kumar <[email protected]>
2 tasks
3 tasks
yendelevium
added a commit
to yendelevium/meteomunch
that referenced
this issue
Oct 20, 2024
- Changed the function signature of the FetchData method in the Provides interface - Added the SetQueryParams method to the providers aligned to the concerns raised in tinkershack#13 Resolves tinkershack#13 References tinkershack#5
raamsri
pushed a commit
that referenced
this issue
Oct 22, 2024
* Implement SetQueryParams in the Provider Interface - Changed the function signature of the FetchData method in the Provides interface - Added the SetQueryParams method to the providers aligned to the concerns raised in #13 Resolves #13 References #5 * Reduce redundant passing of queryParamters - Add queryParams field on the providers - Update SetQueryParams method to set the queryParams field on the provider - Update NewOpenMeteoProvider() and NewMeteoBlueProvider() to set default QPs on the client - Update FetchData() to only set the coords, and not the entire QPs * Address the latitude-longitude/lat-lon discrepancy in the queryParans of MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
feature: Define and implement Provider interface for providers package
Summary:
Implement
Provider
interface in theproviders
package. This interface will provide methods for interacting with various weather data providers.Package
providers
must offer an interface and a factory method for weather data providers. This package is designed to facilitate the integration of various weather data providers by defining a common interface that each provider must implement. It may include a factory method to instantiate the appropriate provider based on a given name.The main components of this package would be(Preemptively. This may change):
Expected usage:
Details:
Interface Description:
Provider
interface:Package Description:
Outcome:
Dependencies:
Acceptance Criteria:
FetchData
method in the new package. More may be added as necessary.Additional Information:
The text was updated successfully, but these errors were encountered: