Feat: Support Google Authentication #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple NestrisChamps from Twitch identities and Support google Auth as a secondary means of logging into nestrischamps.
Has been tested locally well, but might still cause trouble, a backup of the database has been taken
Note: Twitch IDs no longer guaranteed to be available in NestrisChamps
Since NTC used to just blindly trust whatever Twitch provided, twitch ids (e.g.
yobi9) were guaranteed by Twitch to be unique. Now that other parties can provide identities, users need to be able to provide / modify their ids, and Nestrischamps needs to manage the uniqueness itself. In particular, that means that someone registering with google could "chope" the twitch id of a twitch userd who has not yet registered into TwitchUnrelated bonus, the PR upgrades bulma, and so the main pages now support dark mode.