Fix SCPyPlotExt #398
Merged
Fix SCPyPlotExt #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SCPyPlotExt` had two problems: - the default argument to `pdata` is `Profile.fetch()`, but `Profile` was not imported - the extension was not adding methods to `SnoopCompile.pgdsgui` As a result, the tutorial on `pgdsgui` was broken. This commit fixes both of these issues.
Co-authored-by: Charles Kawczynski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 78.96% 82.84% +3.87%
==========================================
Files 17 12 -5
Lines 2054 1784 -270
==========================================
- Hits 1622 1478 -144
+ Misses 432 306 -126 ☔ View full report in Codecov by Sentry. |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SCPyPlotExthad three problems:pdataisProfile.fetch(), butProfilewas not importedSnoopCompile.pgdsguiprep_riwas failing withUndefVarError: lookup_firstip! not definedAs a result, the tutorial on
pgdsguiwas broken.This commit fixes these issues. In the process, I also fixed syntax highlighing in a couple of places in the documentation.