Turn Cthulhu and JET into weakdeps #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create CthulhuExt and JETExt extension packages
aviatesk
reviewed
Apr 10, 2024
|
Thanks for your PR, @mkitti , and sorry for being late to response! Unfortunately, this seems to be broken on Julia versions earlier than 1.8 (pre pkg extensions), so I'd like to go with #379 first. I'd appreciate if we can merge the change to make Cthulhu integration lazy from this PR though. Do you want to update this PR, or want me to work on that? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 78.96% 84.09% +5.12%
==========================================
Files 17 17
Lines 2054 2163 +109
==========================================
+ Hits 1622 1819 +197
+ Misses 432 344 -88 ☔ View full report in Codecov by Sentry. |
|
Closing to rebase and refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create CthulhuExt and JETExt extension packages
Cthulhu.jl and JET.jl are rather large and complicated dependencies.
By making them weak dependencies, we increase the likelihood that SnoopCompile.jl could be loaded on development branches of Julia.
At the time of this writing, SnoopCompile.jl cannot be loaded on the Julia 1.11 branch due to an issue with Cthulhu precompilation.