Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of metadata push and fire-and-forget request types in rRPC #9

Open
y9vad9 opened this issue Jul 22, 2024 · 0 comments · May be fixed by #12
Open

Add support of metadata push and fire-and-forget request types in rRPC #9

y9vad9 opened this issue Jul 22, 2024 · 0 comments · May be fixed by #12
Assignees

Comments

@y9vad9
Copy link
Member

y9vad9 commented Jul 22, 2024

I am planning to implement Fire-and-Forget through message-marker in the following way:

rpc foo(Bar) returns (Ack);

And for the metadata push:

rpc foo(Ack) returns (Ack);

So, effectively, Ack means nothing to be send, for the fire-and-forget we expect to send data, but never receive a response – that's why there's Ack. For the metadata push, we don't expect to have request/response data to be sent/received – that's why we use Ack for the both.

In addition, Ack can be considered as google.protobuf.Empty alternative, but as it can lead to the misunderstanding the concepts and compatibility problems (that gRPC and google.protobuf.Empty does not have – there's not dedicated request types as it's in the RSocket), we introduce alternative structure. Naming is still considered.

@y9vad9 y9vad9 self-assigned this Jul 22, 2024
@y9vad9 y9vad9 linked a pull request Aug 9, 2024 that will close this issue
5 tasks
@y9vad9 y9vad9 changed the title Add support of metadata push and fire-and-forget request types in RSP Add support of metadata push and fire-and-forget request types in rRPC Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant