-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is entr
redundant in the 102-jib-live-update example?
#24
Comments
Sort of! This is a good question @hiremaga In this example, Spring Dev tools also do their own live-reloading. We touch on this a bit in the tutorial: Re:
Ah, this is subtle! The recommended example does use So why do we recommend
i haven't evaluated recently whether spring-dev-tools is in (2) or (3). But lots of users don't know how to evaluate how well their framework supports live-reload (and file bugs against us about it), so sometimes our examples err on the side of redundancy. Maybe it would help to leave a note about this in the README? ya, if you're able to wire up a framework-native restart that works for you, you can remove the Tilt general-purpose one. |
Thanks for the clarification @nicks, both the subtlety about A note in the README might help. Another approach might be having the examples that start off without spring-dev-tools initially and introducing it in a new example in lieu of I've been playing around with Spring Boot and Tilt so I might be able to submit a PR for this. WDYT? |
Yes, a PR to add some notes and pointers on spring-dev-tools would be much appreciated! (we're certainly not experts on Spring Boot) |
tilt-example-java/102-jib-live-update/Tiltfile
Line 18 in 5aa9b4e
This example also includes spring-dev-tools, which automatically restarts the Spring Boot
ExampleApplication
without restarting the entire Java process. The recommended example seems to rely on this this and doesn't useentr
in its entrypoint.Is there something different about using
jib
that makesentr
necessary for live updates?The text was updated successfully, but these errors were encountered: